Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1337) Warn and unset any of the legacy *_GEM_VERSION env vars #671

Merged
merged 2 commits into from
Jun 3, 2019
Merged

(PDK-1337) Warn and unset any of the legacy *_GEM_VERSION env vars #671

merged 2 commits into from
Jun 3, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented May 30, 2019

No description provided.

@coveralls
Copy link

coveralls commented May 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 93.288% when pulling 2ac43e4 on rodjek:pdk-1337 into b156261 on puppetlabs:master.

@rodjek rodjek force-pushed the pdk-1337 branch 2 times, most recently from 58245f2 to dc207d6 Compare May 30, 2019 08:30
scotje
scotje approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one question but overall looks good!

lib/pdk/logger.rb Outdated Show resolved Hide resolved
scotje
scotje approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rodjek rodjek merged commit 2cb86ed into puppetlabs:master Jun 3, 2019
@rodjek rodjek deleted the pdk-1337 branch June 3, 2019 23:24
@rodjek rodjek mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodjek @coveralls @scotje @chelnak